Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Patch for ugly patch of PatchWizard.cpp

subcommander
Discussion topic

Back to topic list

Patch for ugly patch of PatchWizard.cpp

Author jschmitt
Full name Jochen Schmitt
Date 2008-10-09 11:41:24 PDT
Message -----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hallo,

unfortunatley, I have to find out, that the third page of the new
project wizard look very ugly,
because the hieght of the textboxes are smmaler then the used font.

So I have try to create a patch to fix this issue. Unfortunately,
There is another issue
with the information text which is to long to to into the page of the
wizard.

Above I will post the patch which I have created. Perhapse anyone has
a solution
for the long information text.

Best Regards:

Jochen Schmitt

diff -up subcommander-2.0.0b4​/subcommander/Projec​tWizard.cpp.gui
subcommander-2.0.0b4​/subcommander/Projec​tWizard.cpp
- --- subcommander-2.0.0b4​/subcommander/Projec​tWizard.cpp.gui
 2008-08-03 23:10:59.000000000 +0200
+++ subcommander-2.0.0b4​/subcommander/Projec​tWizard.cpp 2008-10-09
20:16:45.000000000 +0200
@@ -20,6 +20,7 @@
 #include <QtGui/QLineEdit>
 #include <QtGui/QTextEdit>
 #include <QtGui/QFileDialog>
+#include <QtGui/QScrollArea>
 #include <QtCore/QVariant>
 #include <QtCore/QRegExp>
 
@@ -241,12 +242,15 @@ public:
       QLabel* lBranchesUrl = new QLabel( branchesUrl, _q("branches
URL:"), this );
       QLabel* lTagsName = new QLabel( tagsName, _q("tags Name:"),
this );
       QLabel* lTagsUrl = new QLabel( tagsUrl, _q("tags URL:"),
this );
- - _std = new QPushButton( _q("Standard Layout"),
this );
+
+ _std = new QPushButton( _q("Standard Layout"), this );
 
       QLabel* text = new QLabel( _q("enter the branches and tags url
for "
         "your project. If you don't use branches or tags just press
finish."), this );
       text->setWordWrap(true);
 
+ QScrollArea* sv = new QScrollArea( this);
+
       QLabel* info = new QLabel( _q("Setting both makes branching
and tagging "
         "a lot easier because you will not have to select or enter a
target url "
         "for a branch or tag when you like to create one. You will
only have to "
@@ -257,10 +261,14 @@ public:
         "If you do not set the urls the bookmarks will not be
visible. Both "
         "bookmarks can be added or changed at any time from the
project (context) "
         "menu or the bookmark (context) menu. Their names can also be
changed by "
- - "'in place' editing the corresponding bookmark."), this );
+ "'in place' editing the corresponding bookmark."), sv );
       info->setWordWrap(true);
+ sv->setMinimumHeight(50);
+ sv->setHorizontal​ScrollBarPolicy( Qt::ScrollBarAlwaysOff);
+ sv->setFocusPolic​y(Qt::NoFocus);
+ sv->setWidget (info);
 
- - l->setSpacing(10);
+ l->setSpacing(5);
       l->addWidget( text, 0, 0, 1, 2 );
       l->addWidget( lBranchesName, 1, 0 );
       l->addWidget( branchesName, 1, 1 );
@@ -271,7 +279,7 @@ public:
       l->addWidget( lTagsUrl, 4, 0 );
       l->addWidget( tagsUrl, 4, 1 );
       l->addWidget( _std, 5, 1 );
- - l->addWidget( info, 6, 0, 1, 2 );
+ l->addWidget( sv, 6, 0, 1, 2 );
       l->setRowStretch( 7, 1 );
 
       registerField("BranchesName*", branchesName);
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkjuUEkA​CgkQT2AHK6txfgzJ/gCg​/SctvtpVMXDHQV8v/tb9​cmUF
BSIAn3ncpSzv2zYb/Ug9​bHfYE5YwvOww
=aAI3
-----END PGP SIGNATURE-----

« Previous message in topic | 1 of 3 | Next message in topic »

Messages

Show all messages in topic

Patch for ugly patch of PatchWizard.cpp jschmitt Jochen Schmitt 2008-10-09 11:41:24 PDT
     Re: Patch for ugly patch of PatchWizard.cpp hauner Martin Hauner 2008-10-25 15:19:49 PDT
     Re: Patch for ugly patch of PatchWizard.cpp hauner Martin Hauner 2008-11-09 09:47:50 PST
Messages per page: