Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Basic log (aka view history) implementation

subcommander
Discussion topic

Back to topic list

Basic log (aka view history) implementation

Author Alexander Jasper <alexander dot jasper at gmx dot net>
Full name Alexander Jasper <alexander dot jasper at gmx dot net>
Date 2004-09-02 14:42:59 PDT
Message Hi!

I've implemented some basic log functionality for sc. This is far from
complete but it is certainly a first step. These are the main things
that are missing:
- Currently works only in the repository files. Needs be called from the
working copy files as well. This shouldn't be difficult. This is because
I don't have a working copy with a working repository connection arround
to test that. (cound check out svn it self, though...)
- prevent buttons from getting HUGE. I've toyed around with QSpacerItem
but could not get it to work.
- Should work on the tree view on the left side, too?
- Don't use a dialog for log output, but just change the view on the
right. That is, don't display files, but log messages. This is how its
done in perfoce and, if I remember correctly, in SourceSafe as well.
- Integrate "LogMessageDetails" into the main log-outout dialog, that is
display the log message at the bottom like TortoiseSVN or s.th.

Just one additional note. Pay attention to the usage of QWaitCondtion in
the code. This not comparable to Win32 Event out of the box.
this code:

QWaitCondition w;
w.wakeAll/One();
w.wait();

is a deadlock. Only those threads are woken up that block on the
condition in that exact moment when wakeXXX is called.
For this reason I build a Condition class that behaves more or less like
a Win32 Event.

I could have fixed more of the issues above but I don't think its a good
idea to base to much stuff on a too old code base. Therefore I've
attached a path against sc 0.2. If you integrate that (or a somehow
adopted version) we could discuss how to evolve this further.
This would then be based on merged version.

regards

Alexander
Attachments

« Previous message in topic | 1 of 4 | Next message in topic »

Messages

Show all messages in topic

Basic log (aka view history) implementation Alexander Jasper <alexander dot jasper at gmx dot net> Alexander Jasper <alexander dot jasper at gmx dot net> 2004-09-02 14:42:59 PDT
     Re: Basic log (aka view history) implementation hauner Martin Hauner 2004-09-04 03:55:05 PDT
         Re: Basic log (aka view history) implementation Alexander Jasper <alexander dot jasper at gmx dot net> Alexander Jasper <alexander dot jasper at gmx dot net> 2004-09-04 09:27:00 PDT
             Re: Basic log (aka view history) implementation hauner Martin Hauner 2004-09-05 12:00:11 PDT
Messages per page: